This repository has been archived by the owner on Feb 16, 2024. It is now read-only.
Consume enumerators for types inheriting AsyncOperation. #516
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Enumerators for the types inheriting
AsyncOperation
are not consumed as expected. AllAsyncOperation
s haveisDone
property that needs to be checked before completing the enumeration. This is done correctly for the base type by using theUnwrap...
method, but the types inheriting it are handled as an unkown case.Example
Without this fix, when a webrequest is performed in Edit-mode using
UnityWebRequest.Get()
andAsAsyncOperationObservable
extension, the observable publishes a value immediately without waiting request to complete.Solution
Changed comparison to handle all types assignable to the
AsyncOperation
base class, so the completion is waited for them before publishing a value.