Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor get_basic_words #507

Merged
merged 1 commit into from
Sep 29, 2022
Merged

refactor get_basic_words #507

merged 1 commit into from
Sep 29, 2022

Conversation

odashi
Copy link
Contributor

@odashi odashi commented Sep 25, 2022

Part of #473

This change refactors get_basic_words to use SingleSpaceTokenizer. The change also contains some unit tests.

@odashi odashi requested a review from neubig September 25, 2022 16:40
pfliu-nlp
pfliu-nlp approved these changes Sep 29, 2022
View reviewed changes
Copy link
Collaborator

@pfliu-nlp pfliu-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@odashi odashi merged commit 187dc88 into main Sep 29, 2022
@odashi odashi deleted the refactor-get-basic-words branch September 29, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neubig neubig neubig approved these changes

@pfliu-nlp pfliu-nlp pfliu-nlp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@odashi @neubig @pfliu-nlp