Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeprecationWarning - Buffer in node v7 #304

Closed
alexichepura opened this issue Oct 13, 2016 · 7 comments
Closed

DeprecationWarning - Buffer in node v7 #304

alexichepura opened this issue Oct 13, 2016 · 7 comments
Labels
hygiene

Comments

@alexichepura
Copy link

Node v7 from https://nodejs.org/download/test/
To see the tracing node --trace-deprecation server

DeprecationWarning: Using Buffer without `new` will soon stop working. Use `new Buffer()`, or preferably `Buffer.from()`, `Buffer.allocUnsafe()` or `Buffer.alloc()` instead.
    at Buffer (buffer.js:79:13)
    at Connection._sendProof (/www/node_modules/rethinkdbdash/lib/connection.js:281:40)
    at InternalFieldObject.ondone (/www/node_modules/rethinkdbdash/lib/connection.js:255:12)
@matth3wga0 matth3wga0 mentioned this issue Oct 28, 2016
Closed
@chrisvariety
Copy link

See also rethinkdb/rethinkdb#6144

@abalabahaha abalabahaha mentioned this issue Nov 4, 2016
Closed
@neumino neumino closed this as completed in 1fd5b27 Nov 6, 2016
@jtlapp
Copy link

jtlapp commented Nov 17, 2016

I get this is v7.1.0, which is the latest stable. Do we have to wait for 8.0.0 for the fix? Thanks!

@neumino
Copy link
Owner

neumino commented Nov 22, 2016

What version of rethinkdbdash are you using?

@jtlapp
Copy link

jtlapp commented Nov 22, 2016

Oops, looks like I left my comment on the wrong repo. Sorry, I meant to ask that of the node guys.

@krishangupta
Copy link

I still get this in 7.2. Anyone else?

@neumino
Copy link
Owner

neumino commented Nov 28, 2016

What version of rethinkdbdash are you using?

@krishangupta
Copy link

@neumino my mistake - I thought this was a forum about node. It was the first result on Google so I just assumed. Thanks for replying!

thejsj added a commit to thejsj/rethinkdbdash that referenced this issue Dec 17, 2016
@thejsj
Merge branch 'master' of github.com:neumino/rethinkdbdash
b5c33dc 
* 'master' of github.com:neumino/rethinkdbdash: (304 commits)
  Fix leaked variable from test
  Bump to 2.3.27
  Fix neumino#313
  Bump to 2.3.26
  fix: return null where new Promises are created but not returned
  Fix leak in tests
  Fix leak in tests
  Bump to 2.3.25
  Make identification errors operational such that they can be properly caught - Fix neumino#295
  Bump to 2.3.24
  Close the stream if an error is emitted since we can't recover frm it
  Remove the use of Buffer with new for node 7 - Fix neumino#304
  Wrap sending the proof in a try/catch in case the connection is closed - Fix neumino#296
  Bump to 2.3.23
  Prevent bluebird warning - Fix neumino#287
  Bump to 2.3.22
  Prevent bluebird warning - Fix neumino#285
  function r: remove unused parameter `options`
  readme: minor typo fix
  Bump to 2.3.21
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hygiene
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@chrisvariety @jtlapp @neumino @krishangupta @alexichepura