Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Decompress kwargs #100

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Fix Decompress kwargs #100

merged 1 commit into from
Jun 26, 2024

Conversation

Satrat
Copy link

@Satrat Satrat commented Jun 26, 2024 •
edited
Loading

decompress was failing for non-packed models after adding the name_to_scheme arg. Adding a kwargs field to all the decompressors fixed the issue

rahul-tuli
rahul-tuli approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@rahul-tuli rahul-tuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rahul-tuli
Copy link
Member

LGTM once tests are green!

@Satrat Satrat merged commit 7e94b07 into main Jun 26, 2024
1 check passed
@Satrat Satrat deleted the fix_decomp_kwargs branch June 26, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahul-tuli rahul-tuli rahul-tuli approved these changes

@bfineran bfineran bfineran approved these changes

@dsikka dsikka Awaiting requested review from dsikka

@horheynm horheynm Awaiting requested review from horheynm

@dbogunowicz dbogunowicz Awaiting requested review from dbogunowicz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Satrat @rahul-tuli @bfineran