Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Quantization Scheme Standards for better readability #106

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

markurtz
Copy link
Member

@markurtz markurtz commented Jul 3, 2024

Summary

Enhances the quantization module by expanding the quantization schemes, inline docs, and default values to improve readability and usability.

Details

  • Added new quantization schemes for 4-bit weights and 8-bit activations (W4A8) and improved documentation for existing schemes.
  • Updated the QuantizationArgs to include comprehensive default values.
  • Added docs throughout to clarify the code

Test Plan

  • Manual review
  • Current automated tests

@dbogunowicz
Copy link
Contributor

It's a copy of: #105 isnt it @markurtz ?

anmarques
anmarques previously approved these changes Jul 3, 2024
@markurtz markurtz force-pushed the quantization-schemes branch from 8942895 to bb9dbad Compare July 8, 2024 18:29
@markurtz markurtz changed the title Add Standard Quantization Schemes and Expand Default Values for Better Readability Update Quantization Scheme Standards for better readability Jul 8, 2024
@markurtz
Copy link
Member Author

markurtz commented Jul 9, 2024

It's a copy of: #105 isnt it @markurtz ?

#105 landed, but didn't include the fixes I wanted to get in with it. I've rebased on current state of main so they no longer contain duplicate code

@Satrat Satrat merged commit 0c2d88b into main Jul 12, 2024
1 check passed
@Satrat Satrat deleted the quantization-schemes branch July 12, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants