Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #121

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Update README.md #121

merged 2 commits into from
Aug 12, 2024

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Aug 5, 2024

No description provided.

Copy link

@Satrat Satrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for updating this! I think we should also revisit the examples in the main README (they're quite out of date), but good to merge this as-is aside from one comment

README.md Show resolved Hide resolved
@mgoin
Copy link
Member Author

mgoin commented Aug 5, 2024

Yeah I was trying to make new examples but it kept turning into a lot of code. I think it would be helpful to demonstrate small examples of what quantizing a Linear module to int8/fp8 looks like in code and in the final checkpoint. Having an example of the checkpoint format is really important front and center

@mgoin mgoin merged commit b494862 into main Aug 12, 2024
1 check failed
@mgoin mgoin deleted the mgoin/update-readme branch August 12, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants