additional fixes for HFQuantizer compatibility #136
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horheynm
previously approved these changes
Aug 20, 2024
kylesayrs
reviewed
Oct 2, 2024
| @@ -205,6 +205,10 @@ def parse_quantization_config( | |||
| if hasattr(compression_config, QUANTIZATION_CONFIG_NAME): | |||
| # for loaded HFQuantizer config | |||
| return getattr(compression_config, QUANTIZATION_CONFIG_NAME) | |||
| elif isinstance(compression_config, dict) and ( | |||
|
@kylesayrs @dsikka is this diff still needed and in progress given the landing of HF quantizer support? |
kylesayrs
reviewed
Oct 22, 2024
| parameter.data = new_param_data.to(device).to(dtype) | ||
| try: | ||
| parameter.data = new_param_data.to(device).to(dtype) | ||
| except RuntimeError: |
There was a problem hiding this comment.
This is better handled by #193
|
All the changes here have already been made or have open PRs to fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
handling of assigning values to meta parameters on load and deserializing quant configs