Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Fix quant config parsing #162

Merged
merged 2 commits into from
Sep 25, 2024
Merged

[Bugfix] Fix quant config parsing #162

merged 2 commits into from
Sep 25, 2024

Conversation

kylesayrs
Copy link
Contributor

@kylesayrs kylesayrs commented Sep 25, 2024 •
edited
Loading

Purpose

Changes

  • Optionally pop off version when parsing quantization config

Testing

  • Previously broken llm-compressor tests now pass, namely tests/llmcompressor/transformers/sparsification/test_compress_tensor_utils.py

mgoin
mgoin approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, I saw the other failures on the CI and didn't notice the new ones

src/compressed_tensors/compressors/model_compressor.py Show resolved Hide resolved
@mgoin mgoin merged commit 44dda93 into main Sep 25, 2024
1 check passed
@mgoin mgoin deleted the kylesayrs/add-version-to-q-config branch September 25, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoin mgoin mgoin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylesayrs @mgoin