-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup ModelCompressor, fix reload bugs #172
Conversation
@kylesayrs The first was set-up by design. This gives us two separate pathways, which we would like to keep for the time being |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest opening separate PRs for each bug fix that you'd like to have changed. Otherwise, the PR can't be accepted in its current state.
@dsikka w.r.t. your first comment, doesn't this mean that users can no longer load back models using |
Please read through the description of the PR you referenced: #164 |
@dsikka When I was referring to loading back models, I wasn't referring to legacy models, I was referring to models compressed today (with There are a couple reasons which motivate why
|
Relevant: #164 (review)
|
Split up into 3 PRs, some of which are pending greater changes later |
Purpose
Track changes across PRs