Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quantization Scheme Validation #209

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Conversation

kylesayrs
Copy link
Contributor

@kylesayrs kylesayrs commented Nov 19, 2024

Purpose

  • Make QuantizationScheme more user friendly by adding model validation
  • This PR is only meant to guard against a few cases I encountered which were not explicitly covered downstream, so feel free to suggest any other invalid combinations we want to guard against.

Changes

  • Add model validator to QuantizationScheme

Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
@kylesayrs kylesayrs self-assigned this Nov 19, 2024
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
horheynm
horheynm previously approved these changes Nov 21, 2024
Copy link
Contributor

@dsikka dsikka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need rebase

@dsikka dsikka merged commit c6197ce into main Nov 25, 2024
1 check passed
@dsikka dsikka deleted the kylesayrs/quant-scheme-validation branch November 25, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants