Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Channel-wise Quantization #27

Closed
wants to merge 4 commits into from
Closed

Channel-wise Quantization #27

wants to merge 4 commits into from

Conversation

bfineran
Copy link
Contributor

@bfineran opening branch to leave comments

bfineran
bfineran commented Apr 18, 2024
View reviewed changes
Copy link
Contributor Author

@bfineran bfineran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right direction - see note on vectorizing. I think it should work out of the box after that

src/compressed_tensors/quantization/observers/min_max.py Outdated Show resolved Hide resolved
src/compressed_tensors/quantization/observers/min_max.py Outdated Show resolved Hide resolved
src/compressed_tensors/quantization/observers/min_max.py Outdated Show resolved Hide resolved
@horheynm horheynm changed the title [WIP] Channel-wise Quantization Channel-wise Quantization Apr 19, 2024
bfineran
bfineran commented Apr 22, 2024
View reviewed changes
Copy link
Contributor Author

@bfineran bfineran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: testing and generalize across observers

@horheynm horheynm closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@horheynm horheynm horheynm left review comments

@Satrat Satrat Satrat left review comments

Assignees

@horheynm horheynm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bfineran @Satrat @horheynm