Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for aliased scheme settings in quant config #40

Merged
merged 3 commits into from
May 22, 2024
Merged

Support for aliased scheme settings in quant config #40

merged 3 commits into from
May 22, 2024

Conversation

bfineran
Copy link
Contributor

this PR would support aliasing common quantization schemes in the quant config by allowing these aliases to be used as group_name if the target list is set as the values.

example:

config_groups:
  W8A8: [Linear]
  W4A16: [Embedding]

@bfineran bfineran requested a review from Satrat April 25, 2024 21:03
@bfineran bfineran self-assigned this Apr 25, 2024
@mgoin
Copy link
Member

mgoin commented Apr 29, 2024

I think this is a great idea!

@bfineran bfineran marked this pull request as ready for review May 22, 2024 18:50
@bfineran bfineran changed the title [Proposal] Support for aliased scheme settings in quant config Support for aliased scheme settings in quant config May 22, 2024
@bfineran bfineran merged commit 7572c7b into main May 22, 2024
1 check passed
@bfineran bfineran deleted the scheme-aliases branch May 22, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahul-tuli rahul-tuli rahul-tuli approved these changes

@Satrat Satrat Awaiting requested review from Satrat

Assignees

@bfineran bfineran

@rahul-tuli rahul-tuli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bfineran @mgoin @rahul-tuli