Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update target match conditions; make public #44

Merged
merged 3 commits into from
Apr 30, 2024
Merged

Update target match conditions; make public #44

merged 3 commits into from
Apr 30, 2024

Conversation

dsikka
Copy link
Contributor

@dsikka dsikka commented Apr 26, 2024

Summary

  • Update the match conditions between layers and values defined in target/ignore
  • Make the function public for vllm use

Testing

  • Ran tests under quantization which all pass

@dsikka dsikka requested a review from Satrat April 26, 2024 19:19
@dsikka dsikka requested a review from bfineran April 26, 2024 19:31
@dsikka dsikka mentioned this pull request Apr 29, 2024
Merged
@Satrat Satrat merged commit b0668e2 into main Apr 30, 2024
2 checks passed
@Satrat Satrat deleted the update_condition branch April 30, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bfineran bfineran bfineran approved these changes

@Satrat Satrat Satrat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsikka @Satrat @bfineran