[BugFix] Update code to be compatible with py38 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horheynm
approved these changes
May 6, 2024
dbogunowicz
approved these changes
May 6, 2024
bfineran
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In one of the places we use shorthand operator
|=to combine two dicts, this led to a py38 test failure as this syntax was introduced in python 3.9; Fix is to usedict.update(...)over|=Use
dict.update(...)over|=as it was added inpy39Test plan: re-ran failing test with
py38and it works:(.venv) ➜ sparseml git:(main) pytest tests/sparseml/transformers/sparsification/test_compress_tensor_utils.py::test_sparse_model_reload ======================================================================= test session starts ======================================================================== rootdir: /root/projects/sparseml configfile: pyproject.toml plugins: mock-3.14.0, hydra-core-1.3.2, rerunfailures-14.0 collected 5 items tests/sparseml/transformers/sparsification/test_compress_tensor_utils.py ..... [100%] ========================================================================= warnings summary =========================================================================