This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
fix install conflict due to torchvision 0.18.1 #348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhuangnm
requested review from
dbarbuzzi,
mgoin,
andy-neuma,
derekk-nm and
robertgshaw2-redhat
derekk-nm
approved these changes
Jun 28, 2024
|
Is this an upstream issue as well? |
dbarbuzzi
approved these changes
Jun 28, 2024
It looks upstream has fixed it in this PR: vllm-project#5772 but a bit different. |
|
Maybe we can just wait for the fix in next upstream sync? @mgoin @robertgshaw2-neuralmagic It's not blocking testing now and jobs don't fail due to the error. |
|
Fixed in upstream, no changes needed here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit torchvision version to <=0.18.0 in requirements-test.txt.