Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker Finalization #1506

Merged
merged 9 commits into from
Apr 9, 2023
Merged

Docker Finalization #1506

merged 9 commits into from
Apr 9, 2023

Conversation

rahul-tuli
Copy link
Member

@rahul-tuli rahul-tuli commented Apr 4, 2023 •
edited
Loading

This PR will update our GHA and dockerfiles:

  • Docker Images should be built and pushed whenever a release is published (Update GHA workflow trigger)
  • Dockerfile updates to install from pypi and support for nightlies
  • Image naming updates, GHA workflow file

The Dockerfile also includes support to build a dev container with the following command within docker directory:

DOCKER_BUILDKIT=1 \
  docker build  \
  --target dev \
  --build-arg DEPS=dev \
  --build-arg BUILDKIT_INLINE_CACHE=1 \
  -t sparseml:dev .

The Images will be pushed to ghcr.io and will be available under pushed packages for the repo

@rahul-tuli rahul-tuli self-assigned this Apr 4, 2023
@rahul-tuli rahul-tuli marked this pull request as ready for review April 7, 2023 13:18
KSGulin
KSGulin previously approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@KSGulin KSGulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I like the use of console prints for step/progress tracking

corey-nm
corey-nm previously approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@corey-nm corey-nm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice work! 👍

docker/Dockerfile Show resolved Hide resolved
.github/workflows/build-and-publish-release-images.yaml Show resolved Hide resolved
@rahul-tuli rahul-tuli dismissed stale reviews from corey-nm and KSGulin via c1b7f57 April 7, 2023 14:32
@rahul-tuli rahul-tuli merged commit 9382d2f into main Apr 9, 2023
@rahul-tuli rahul-tuli deleted the docker-finalizaton branch April 9, 2023 17:21
bfineran pushed a commit that referenced this pull request May 8, 2023
@rahul-tuli
Docker Finalization (#1506)
35eefb0
bfineran pushed a commit that referenced this pull request May 8, 2023
@rahul-tuli @bfineran
Docker Finalization (#1506)
adce820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corey-nm corey-nm corey-nm approved these changes

@KSGulin KSGulin KSGulin approved these changes

@bfineran bfineran bfineran approved these changes

@dbogunowicz dbogunowicz Awaiting requested review from dbogunowicz

Assignees

@rahul-tuli rahul-tuli

Labels
mle-team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rahul-tuli @bfineran @KSGulin @corey-nm