-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: ModelAnalysis.from_onnx(...)
to work with ModelProto
#253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSGulin
approved these changes
Jan 30, 2023
bfineran
approved these changes
Jan 30, 2023
horheynm
pushed a commit
that referenced
this pull request
Feb 1, 2023
search search, download draft draft, successful search and download draft Update: `ModelAnalysis.from_onnx(...)` to additionally work with loaded `ModelProto` (#253) refactor search, download
horheynm
added a commit
that referenced
this pull request
Mar 20, 2023
* Dummy graphql requests module * graphql api request * return Model instances * Update NOTICE (#242) license name change * bump main to 1.4.0 (#246) Co-authored-by: dhuang <dhuang@MacBook-Pro.local> * Pin numpy version to <=1.21.6 (#247) search search, download draft draft, successful search and download draft Update: `ModelAnalysis.from_onnx(...)` to additionally work with loaded `ModelProto` (#253) refactor search, download * lint * pass tests * init files * lint * Add dummy test using test-specific subclass * tests * add incremeent_downloads=False * allow empty arguments * comments * refactor from main merge * comments * da comments --------- Co-authored-by: Danny Guinther <dguinther@neuralmagic.com> Co-authored-by: Jeannie Finks <74554921+jeanniefinks@users.noreply.github.com> Co-authored-by: dhuangnm <74931910+dhuangnm@users.noreply.github.com> Co-authored-by: dhuang <dhuang@MacBook-Pro.local> Co-authored-by: Rahul Tuli <rahul@neuralmagic.com>
horheynm
added a commit
that referenced
this pull request
Mar 21, 2023
* Dummy graphql requests module * graphql api request * return Model instances * Update NOTICE (#242) license name change * bump main to 1.4.0 (#246) Co-authored-by: dhuang <dhuang@MacBook-Pro.local> * Pin numpy version to <=1.21.6 (#247) search search, download draft draft, successful search and download draft Update: `ModelAnalysis.from_onnx(...)` to additionally work with loaded `ModelProto` (#253) refactor search, download * lint * pass tests * init files * lint * Add dummy test using test-specific subclass * tests * add incremeent_downloads=False * allow empty arguments * comments * query parser, allow dict as input, add tests for extra functionality * restore models.utils * restore models.utils * comments * remove redundant code --------- Co-authored-by: Danny Guinther <dguinther@neuralmagic.com> Co-authored-by: Jeannie Finks <74554921+jeanniefinks@users.noreply.github.com> Co-authored-by: dhuangnm <74931910+dhuangnm@users.noreply.github.com> Co-authored-by: dhuang <dhuang@MacBook-Pro.local> Co-authored-by: Rahul Tuli <rahul@neuralmagic.com>
horheynm
added a commit
that referenced
this pull request
Apr 12, 2023
* Dummy graphql requests module * graphql api request * return Model instances * Update NOTICE (#242) license name change * bump main to 1.4.0 (#246) Co-authored-by: dhuang <dhuang@MacBook-Pro.local> * Pin numpy version to <=1.21.6 (#247) search search, download draft draft, successful search and download draft Update: `ModelAnalysis.from_onnx(...)` to additionally work with loaded `ModelProto` (#253) refactor search, download * lint * pass tests * init files * lint * Add dummy test using test-specific subclass * tests * add incremeent_downloads=False * allow empty arguments * comments * query parser, allow dict as input, add tests for extra functionality * restore models.utils * restore models.utils * v2 stub * comments * change stubs to ones on prod * lint * Update src/sparsezoo/model/utils.py Co-authored-by: Danny Guinther <dannyguinther@gmail.com> * Update src/sparsezoo/model/utils.py Co-authored-by: Danny Guinther <dannyguinther@gmail.com> * Update src/sparsezoo/api/utils.py Co-authored-by: Danny Guinther <dannyguinther@gmail.com> --------- Co-authored-by: Danny Guinther <dguinther@neuralmagic.com> Co-authored-by: Jeannie Finks <74554921+jeanniefinks@users.noreply.github.com> Co-authored-by: dhuangnm <74931910+dhuangnm@users.noreply.github.com> Co-authored-by: dhuang <dhuang@MacBook-Pro.local> Co-authored-by: Rahul Tuli <rahul@neuralmagic.com> Co-authored-by: Danny Guinther <dannyguinther@gmail.com>
horheynm
added a commit
that referenced
this pull request
Apr 13, 2023
* Dummy graphql requests module * graphql api request * return Model instances * Update NOTICE (#242) license name change * bump main to 1.4.0 (#246) Co-authored-by: dhuang <dhuang@MacBook-Pro.local> * Pin numpy version to <=1.21.6 (#247) search search, download draft draft, successful search and download draft Update: `ModelAnalysis.from_onnx(...)` to additionally work with loaded `ModelProto` (#253) refactor search, download * lint * pass tests * init files * lint * Add dummy test using test-specific subclass * tests * add incremeent_downloads=False * allow empty arguments * comments * query parser, allow dict as input, add tests for extra functionality * restore models.utils * restore models.utils * v2 stub * comments * change stubs to ones on prod * lint * Update src/sparsezoo/model/utils.py Co-authored-by: Danny Guinther <dannyguinther@gmail.com> * Update src/sparsezoo/model/utils.py Co-authored-by: Danny Guinther <dannyguinther@gmail.com> * Update src/sparsezoo/api/utils.py Co-authored-by: Danny Guinther <dannyguinther@gmail.com> --------- Co-authored-by: Danny Guinther <dguinther@neuralmagic.com> Co-authored-by: Jeannie Finks <74554921+jeanniefinks@users.noreply.github.com> Co-authored-by: dhuangnm <74931910+dhuangnm@users.noreply.github.com> Co-authored-by: dhuang <dhuang@MacBook-Pro.local> Co-authored-by: Rahul Tuli <rahul@neuralmagic.com> Co-authored-by: Danny Guinther <dannyguinther@gmail.com>
horheynm
added a commit
that referenced
this pull request
Apr 17, 2023
* fix return type annotation and tests (#282) Co-authored-by: Danny Guinther <dannyguinther@gmail.com> * error handling - send message from graphql (#286) * error handling - send message from graphql Union to Optional error message * error message * comments * tests * tests * change def name * error logic * Stub v2 (#271) * Dummy graphql requests module * graphql api request * return Model instances * Update NOTICE (#242) license name change * bump main to 1.4.0 (#246) Co-authored-by: dhuang <dhuang@MacBook-Pro.local> * Pin numpy version to <=1.21.6 (#247) search search, download draft draft, successful search and download draft Update: `ModelAnalysis.from_onnx(...)` to additionally work with loaded `ModelProto` (#253) refactor search, download * lint * pass tests * init files * lint * Add dummy test using test-specific subclass * tests * add incremeent_downloads=False * allow empty arguments * comments * query parser, allow dict as input, add tests for extra functionality * restore models.utils * restore models.utils * v2 stub * comments * change stubs to ones on prod * lint * Update src/sparsezoo/model/utils.py Co-authored-by: Danny Guinther <dannyguinther@gmail.com> * Update src/sparsezoo/model/utils.py Co-authored-by: Danny Guinther <dannyguinther@gmail.com> * Update src/sparsezoo/api/utils.py Co-authored-by: Danny Guinther <dannyguinther@gmail.com> --------- Co-authored-by: Danny Guinther <dguinther@neuralmagic.com> Co-authored-by: Jeannie Finks <74554921+jeanniefinks@users.noreply.github.com> Co-authored-by: dhuangnm <74931910+dhuangnm@users.noreply.github.com> Co-authored-by: dhuang <dhuang@MacBook-Pro.local> Co-authored-by: Rahul Tuli <rahul@neuralmagic.com> Co-authored-by: Danny Guinther <dannyguinther@gmail.com> --------- Co-authored-by: Danny Guinther <dannyguinther@gmail.com> Co-authored-by: Danny Guinther <dguinther@neuralmagic.com> Co-authored-by: Jeannie Finks <74554921+jeanniefinks@users.noreply.github.com> Co-authored-by: dhuangnm <74931910+dhuangnm@users.noreply.github.com> Co-authored-by: dhuang <dhuang@MacBook-Pro.local> Co-authored-by: Rahul Tuli <rahul@neuralmagic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR,
sparezoo.analysis.ModelAnalysis.from_onnx(...)
methodworked only with filepaths to onnx files, this can be inconvenient especially
if we need to analyze an already loaded onnx model.
Results in the following Error:
After this PR
ModelAnalysis
will work with both loaded onnxModelProto
andlocal filepaths
The same test code(after this PR) now returns a
ModelAnalysis
objectThis will allow easier testing where we will not have to reload onnx files,
and, will be useful for upcoming
PerformanceAnalysis
apiNote: The changes added should not affect existing flows.