-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up relationship between deployment_tar and deployment #389
Conversation
Reminder: once this PR lands, we need to update the relevant pathways to the |
src/sparsezoo/model/model.py
Outdated
# is used when we initialize the model from | ||
# local directory (not stub) and both [some_directory] | ||
# and [some_directory].tar.gz are present | ||
allow_picking_one_from_multiple: bool = False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs better name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like download_from_tar_if_available
…ic/sparsezoo into deployment-tar-cleanup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
best pr ever
Feature Description
Now, any directory that can be downloaded as tar.gz and then unzipped is by default downloaded in such a manner.
This does not prevent us from downloading single, "loose" files from the directory in question.
Downloading the
deployment
directoryNote, that the deployment is downloaded as tar and then unzipped:
Downloading the whole model
Note, that the appropriate folders get downloaded as tars and then unzipped
Downloading a single "loose"
deployment
file