Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

align all ls command options #2995

Merged
merged 4 commits into from
Jun 6, 2023
Merged

Conversation

zubenkoivan
Copy link
Contributor

No description provided.

@zubenkoivan zubenkoivan marked this pull request as draft June 1, 2023 14:26
@zubenkoivan zubenkoivan marked this pull request as ready for review June 2, 2023 07:35
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch coverage: 48.14% and project coverage change: -0.21 ⚠️

Comparison is base (de35f9b) 73.70% compared to head (4143448) 73.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2995      +/-   ##
==========================================
- Coverage   73.70%   73.50%   -0.21%     
==========================================
  Files          70       70              
  Lines       12613    12657      +44     
  Branches     2319     2336      +17     
==========================================
+ Hits         9297     9304       +7     
- Misses       2992     3027      +35     
- Partials      324      326       +2     
Impacted Files Coverage Δ
neuro-sdk/src/neuro_sdk/_disks.py 88.17% <0.00%> (-0.13%) ⬇️
neuro-sdk/src/neuro_sdk/_jobs.py 80.97% <0.00%> (-0.26%) ⬇️
neuro-cli/src/neuro_cli/image.py 39.58% <42.85%> (-1.33%) ⬇️
neuro-cli/src/neuro_cli/job.py 42.83% <42.85%> (-0.55%) ⬇️
neuro-cli/src/neuro_cli/disks.py 50.58% <53.84%> (-2.66%) ⬇️
neuro-cli/src/neuro_cli/secrets.py 60.00% <53.84%> (-3.16%) ⬇️
neuro-cli/src/neuro_cli/blob_storage.py 38.25% <60.00%> (-0.33%) ⬇️
neuro-sdk/src/neuro_sdk/__init__.py 86.04% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@YevheniiSemendiak YevheniiSemendiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!
Some suggestions here. We might address most of them in a separate PRs, but I would rather suggest resolving default filtering of neuro job ps (which is broken atm).

neuro-cli/src/neuro_cli/disks.py Outdated Show resolved Hide resolved
neuro-cli/src/neuro_cli/image.py Outdated Show resolved Hide resolved
neuro-cli/src/neuro_cli/secrets.py Show resolved Hide resolved
neuro-cli/src/neuro_cli/image.py Show resolved Hide resolved
neuro-sdk/src/neuro_sdk/_jobs.py Show resolved Hide resolved
Copy link
Contributor

@YevheniiSemendiak YevheniiSemendiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zubenkoivan zubenkoivan merged commit d788b80 into master Jun 6, 2023
@zubenkoivan zubenkoivan deleted the iz/align-all-ls-command-options branch June 6, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants