add idle job preemption #1927
Merged
add idle job preemption #1927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1927 +/- ##
==========================================
+ Coverage 92.54% 92.60% +0.05%
==========================================
Files 40 41 +1
Lines 6644 6897 +253
Branches 1060 1105 +45
==========================================
+ Hits 6149 6387 +238
- Misses 367 376 +9
- Partials 128 134 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
zubenkoivan
force-pushed
the
iz/idle-job-preemption
branch
2 times, most recently
from
22e7d22
to
d8a8239
Compare
zubenkoivan
commented
Apr 20, 2022
| @@ -167,12 +150,13 @@ def orchestrator_config(self) -> OrchestratorConfig: | |||
| def kube_config(self) -> KubeConfig: | |||
| return self._kube_config | |||
|
|
|||
| # TODO: remove | |||
There was a problem hiding this comment.
cleanup later to avoid unnecessary changes in pr
zubenkoivan
commented
Apr 21, 2022
zubenkoivan
force-pushed
the
iz/idle-job-preemption
branch
from
d5b4668
to
29674ae
Compare
zubenkoivan
force-pushed
the
iz/idle-job-preemption
branch
from
cd2bd8a
to
dd1196a
Compare
zubenkoivan
commented
Apr 26, 2022
| @@ -875,3 +862,7 @@ async def delete_all_job_resources(self, job_id: str) -> None: | |||
| await self._client.delete_all_ingresses(labels=labels) | |||
| await self._client.delete_all_services(labels=labels) | |||
| await self._client.delete_all_network_policies(labels=labels) | |||
|
|
|||
| async def preempt_idle_jobs(self, jobs_to_schedule: list[Job]) -> None: | |||
There was a problem hiding this comment.
Currently not used anywhere. Requires K8s upgrade to at least 1.19 of all clusters
asvetlov
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.