Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeResourcesHandler takes into account failed pods #2185

Merged
merged 3 commits into from
Jul 21, 2024

Conversation

YevheniiSemendiak
Copy link
Contributor

Observed this error on dev cluster, which might be caused by custodian changing the state of the cluster.

When cluster is recreated, k8s schedules all service pods, not all of them are able to fit nodes that are rolling out sequentially.

Some of those pods being scheduled at 1st available node does not fit and get into "Failed" state with OutOfcpu error status.
Failed pod in this case is not removed by k8s and stays bound to node.

This created resource leakage in our NodeResourcesHandler since we did not handle such event.

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.67%. Comparing base (891a963) to head (0e798e5).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (891a963) and HEAD (0e798e5). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (891a963) HEAD (0e798e5)
integration 2 0
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2185       +/-   ##
===========================================
- Coverage   84.33%   69.67%   -14.66%     
===========================================
  Files          41       41               
  Lines        7411     7420        +9     
  Branches     1128     1128               
===========================================
- Hits         6250     5170     -1080     
- Misses        896     2125     +1229     
+ Partials      265      125      -140     
Flag Coverage Δ
integration ?
unit 69.67% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
platform_api/orchestrator/kube_client.py 69.45% <100.00%> (-15.51%) ⬇️
...rm_api/orchestrator/kube_orchestrator_scheduler.py 68.96% <100.00%> (-20.20%) ⬇️

... and 35 files with indirect coverage changes

Copy link
Contributor

@zubenkoivan zubenkoivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@YevheniiSemendiak YevheniiSemendiak merged commit bca303e into master Jul 21, 2024
14 checks passed
@YevheniiSemendiak YevheniiSemendiak deleted the ys/handle-failed-pods branch July 21, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants