NodeResourcesHandler takes into account failed pods #2185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observed this error on dev cluster, which might be caused by custodian changing the state of the cluster.
When cluster is recreated, k8s schedules all service pods, not all of them are able to fit nodes that are rolling out sequentially.
Some of those pods being scheduled at 1st available node does not fit and get into "Failed" state with
OutOfcpu
error status.Failed pod in this case is not removed by k8s and stays bound to node.
This created resource leakage in our NodeResourcesHandler since we did not handle such event.