Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Coveralls failure about "parallel builds" #238

Closed
surchs opened this issue Nov 10, 2023 · 4 comments · Fixed by #263
Closed

Investigate Coveralls failure about "parallel builds" #238

surchs opened this issue Nov 10, 2023 · 4 comments · Fixed by #263
Assignees
Labels
tests Enhancing or fixing tests where functioning is not affected. type:bug Defects in shipped code and fixes for those defects

Comments

@surchs
Copy link
Contributor

surchs commented Nov 10, 2023

This issue has recently crept up in this repo (so far only):

Coveralls fails on the Python 3.10 runner (so far I have only seen it on that version) with the following error:

Can't add a job to a build that is already closed. Build 6829765660 is closed. See docs.coveralls.io/parallel-builds

See e.g. here

The docs in question: docs.coveralls.io/parallel-builds

We should investigate why this happens and if it is on our side or their side

@surchs surchs added type:bug Defects in shipped code and fixes for those defects tests Enhancing or fixing tests where functioning is not affected. labels Nov 10, 2023
@surchs
Copy link
Contributor Author

surchs commented Nov 10, 2023

Just rerunning the failed test does not seem to help. But simply pushing an empty or almost empty commit to the PR branch appears to reliably resolve the error. See e.g. #237

@alyssadai was this also your experience?

@alyssadai
Copy link
Contributor

Yep. I also found lemurheavy/coveralls-public#1716, which seems relevant but I was discouraged by the long thread and so have not yet read it in detail 🙈

@surchs
Copy link
Contributor Author

surchs commented Dec 12, 2023

also see: neurobagel/planning#89

@alyssadai
Copy link
Contributor

alyssadai commented Dec 13, 2023

Note: this is only happening in the bagel-cli repo, whose test workflow is currently configured differently from our other python tools (api, federation-api) in that the triggers are:

on: [push, pull_request]

instead of

on:
  push:
    branches:
      - main
  pull_request:
  workflow_dispatch:

as well, the bagel-cli is currently the only one that tests two python versions (3.9, 3.10).

Either or both of these could be causing problems for Coveralls.

It's worth noting that the codecov blog post on Python code coverage https://about.codecov.io/blog/python-code-coverage-using-github-actions-and-codecov/ provides an example of a workflow yml that also uses on: [push. pull_request] which we're currently using for the CLI - so maybe our current hooks aren't necessarily the problem?

From a quick search in the codecov repos, this closed issue also seems potentially relevant: codecov/codecov-action#40

All in all, it might not be a bad idea to try switching to codecov for the CLI to see if we can replicate this problem. For now, the other repos don't seem affected.

@alyssadai alyssadai moved this to Implement - Active in Neurobagel Dec 19, 2023
@alyssadai alyssadai moved this from Implement - Active to Implement - Done in Neurobagel Dec 19, 2023
@alyssadai alyssadai self-assigned this Dec 19, 2023
@github-project-automation github-project-automation bot moved this from Implement - Done to Review - Done in Neurobagel Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Enhancing or fixing tests where functioning is not affected. type:bug Defects in shipped code and fixes for those defects
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants