Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use informative names for examples used in tests #72

Open
4 tasks
alyssadai opened this issue Feb 16, 2023 · 5 comments
Open
4 tasks

Use informative names for examples used in tests #72

alyssadai opened this issue Feb 16, 2023 · 5 comments
Labels
PR welcome Issue that is not an internal priority, but external PRs to address it are welcome. refactor Simplifying or restructuring existing code or documentation.

Comments

@alyssadai
Copy link
Contributor

alyssadai commented Feb 16, 2023

Now that we have decided to implement a required --dataset-dir argument and to make the .tsv and .json file paths optional (with the file names being participants.tsv participants.json by default), it may be cleaner to:

  • store each of the example file pairs in its own informatively-named subdirectory inside tests/data

so that we can use the same, default file names within each of those subdirectories and simplify the current parameterization of tests + test CLI runner invocations.

  • also, consider moving bids-examples and neurobagel_examples into data/ ?
@alyssadai alyssadai added importance:medium refactor Simplifying or restructuring existing code or documentation. labels Feb 16, 2023
@github-actions
Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days.
We have applied the stale-issue label to indicate that this issue should be reviewed again and then either prioritized or closed.

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Mar 20, 2023
@github-actions github-actions bot removed the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Jun 12, 2023
@github-actions
Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days.
We have applied the stale-issue label to indicate that this issue should be reviewed again and then either prioritized or closed.

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Jul 12, 2023
@github-actions
Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days.
We have applied the stale-issue label to indicate that this issue should be reviewed again and then either prioritized or closed.

@surchs surchs added the flag:schedule Flag issue that should go on the roadmap or backlog. label Sep 25, 2023
@alyssadai alyssadai removed _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again flag:schedule Flag issue that should go on the roadmap or backlog. labels Sep 27, 2023
@github-actions
Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days.
We have applied the _flag:stale label to indicate that this issue should be reviewed again.
When you review, please reread the spec and then apply one of these three options:

  • prioritize: apply the flag:schedule label to suggest moving this issue into the backlog now
  • close: if the issue is no longer relevant, explain why (give others a chance to reply) and then close.
  • archive: sometimes an issue has important information or ideas but we won't work on it soon. In this case
    apply the someday label to show that this won't be prioritized. The stalebot will ignore issues with this
    label in the future. Use sparingly!

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Oct 28, 2023
@alyssadai alyssadai added the PR welcome Issue that is not an internal priority, but external PRs to address it are welcome. label Dec 18, 2023
@github-actions github-actions bot removed the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Dec 19, 2023
Copy link

github-actions bot commented Mar 6, 2024

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 75 days.
We have applied the _flag:stale label to indicate that this issue should be reviewed again.
When you review, please reread the spec and then apply one of these three options:

  • prioritize: apply the flag:schedule label to suggest moving this issue into the backlog now
  • close: if the issue is no longer relevant, explain why (give others a chance to reply) and then close.
  • archive: sometimes an issue has important information or ideas but we won't work on it soon. In this case
    apply the someday label to show that this won't be prioritized. The stalebot will ignore issues with this
    label in the future. Use sparingly!

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Mar 6, 2024
@github-actions github-actions bot removed the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR welcome Issue that is not an internal priority, but external PRs to address it are welcome. refactor Simplifying or restructuring existing code or documentation.
Projects
Status: No status
Development

No branches or pull requests

2 participants