Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to handling only .tsv input files (to align with other neurobagel tools) #29

Open
4 tasks
alyssadai opened this issue Apr 14, 2023 · 4 comments
Open
4 tasks
Assignees
Labels
flag:discuss Flag issue that needs to be discussed before it can be implemented. good first issue Good issue for a new contributor. type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs

Comments

@alyssadai
Copy link
Collaborator

alyssadai commented Apr 14, 2023

One thing to consider is that CSV is probably still a more common file format for phenotypic (and even other types of) tabular data than TSV, generally speaking. Not sure, however if this is a good enough reason to keep it.

Steps to implement

  • update functions handling input file loading
  • update upload buttons
  • convert existing example bagel files to .tsv (both pheno + imaging)
  • update error messages, docstrings, comments
@alyssadai alyssadai added the type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs label Apr 14, 2023
@github-actions
Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days.
We have applied the stale-issue label to indicate that this issue should be reviewed again and then either prioritized or closed.

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Aug 18, 2023
@github-actions
Copy link

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 30 days.
We have applied the stale-issue label to indicate that this issue should be reviewed again and then either prioritized or closed.

@alyssadai alyssadai added the good first issue Good issue for a new contributor. label Dec 6, 2023
@alyssadai alyssadai added the flag:discuss Flag issue that needs to be discussed before it can be implemented. label Apr 3, 2024
@alyssadai
Copy link
Collaborator Author

@michellewang, any thoughts? I think @nikhil153 is neutral on this issue - not sure if you have an intuition about whether a switch to TSV could reduce usability for generic users.

@michellewang
Copy link
Collaborator

I don't have a preference either -- TSVs can be loaded/saved in Excel etc. so usability shouldn't be greatly reduced compared to CSV in my opinion. And with the ongoing Nipoppy refactor it shouldn't be too hard to make the switch from CSV to TSVs

@alyssadai alyssadai self-assigned this Dec 9, 2024
@alyssadai alyssadai added flag:discuss Flag issue that needs to be discussed before it can be implemented. and removed _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again flag:discuss Flag issue that needs to be discussed before it can be implemented. labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag:discuss Flag issue that needs to be discussed before it can be implemented. good first issue Good issue for a new contributor. type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs
Projects
None yet
Development

No branches or pull requests

2 participants