Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate the CLI to pydantic v2 #180

Closed
3 of 4 tasks
surchs opened this issue Oct 29, 2024 · 2 comments
Closed
3 of 4 tasks

Migrate the CLI to pydantic v2 #180

surchs opened this issue Oct 29, 2024 · 2 comments
Labels
Milestone Used to track other issues that are required to complete the milestone.

Comments

@surchs
Copy link
Contributor

surchs commented Oct 29, 2024 •
edited by alyssadai
Loading

Context

Pydantic v2 has been out for quite a bit. The CLI (and the nodes) are still on v1. That is starting to cause some limitations, e.g. we cannot easily reuse nipoppy schema in our tools because nipoppy is on v2 (with breaking changes).

Why

  • keep code maintainable
  • compatibility with nipoppy (and other projects)

Outcomes

  • CLI uses pydantic v2
  • all tests are still green
  • nothing else has changed

What
@surchs surchs added the Milestone Used to track other issues that are required to complete the milestone. label Oct 29, 2024
@surchs
Copy link
Contributor Author

surchs commented Nov 18, 2024

@alyssadai I believe this milestone is done?

@alyssadai
Copy link
Contributor

Yes - closing!

@github-project-automation github-project-automation bot moved this to Review - Done in Neurobagel Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Milestone Used to track other issues that are required to complete the milestone.
Projects
Neurobagel
Status: Review - Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@surchs @alyssadai