Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated add_pr2project.yml from repos #119

Closed
3 tasks done
alyssadai opened this issue Nov 25, 2024 · 2 comments
Closed
3 tasks done

Remove outdated add_pr2project.yml from repos #119

alyssadai opened this issue Nov 25, 2024 · 2 comments
Assignees
Labels
quick fix Minimal planning and/or implementation work required.

Comments

@alyssadai
Copy link
Contributor

alyssadai commented Nov 25, 2024

This is an old workflow that used to be synced as part of the sync workflow, but was removed in #35. In that PR we added a config option to "delete orphaned files", but it looks like since we refactored the synced file directories at some point since then, this old workflow didn't get deleted cleanly.

The following repos still have this workflow and need it to be deleted:

  • neurobagel/documentation
  • neurobagel/digest
  • neurobagel/project (archived, so less of a problem)

When it runs, it's currently failing due to bad credentials (b/c it's using our deprecated NB_PROJECT_PAT).

@alyssadai alyssadai added the flag:schedule Flag issue that should go on the roadmap or backlog. label Nov 25, 2024
@surchs surchs moved this to Backlog in Neurobagel Nov 26, 2024
@surchs surchs added maint:process Improvement to internal processes type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs and removed flag:schedule Flag issue that should go on the roadmap or backlog. labels Nov 26, 2024
@surchs surchs added the quick fix Minimal planning and/or implementation work required. label Dec 2, 2024
@alyssadai alyssadai self-assigned this Dec 9, 2024
@alyssadai alyssadai removed maint:process Improvement to internal processes type:maintenance Upkeeping efforts & catch-up corrective improvements that are not Features nor Bugs labels Dec 9, 2024
@alyssadai alyssadai moved this from Backlog to Implement - Done in Neurobagel Dec 9, 2024
@surchs surchs moved this from Implement - Done to Review - Active in Neurobagel Dec 9, 2024
@surchs
Copy link
Contributor

surchs commented Dec 9, 2024

Thanks @alyssadai for dealing with this. As I mentioned in https://github.com/neurobagel/project/pull/175, it seems that the bot which replaces the old workflow doesn't work on private repos. We only have the one private repo and we don't really use it much if at all. But it would still be nice to see if we can make the bot work on private repos as well so we have a full solution. Any ideas?

@alyssadai
Copy link
Contributor Author

@github-project-automation github-project-automation bot moved this from Review - Active to Review - Done in Neurobagel Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quick fix Minimal planning and/or implementation work required.
Projects
Status: Review - Done
Development

No branches or pull requests

2 participants