Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document code according to sklearn guidelines #4

Open
jovo opened this issue Jun 5, 2020 · 9 comments
Open

document code according to sklearn guidelines #4

jovo opened this issue Jun 5, 2020 · 9 comments
Assignees
Labels
ndd Neuro Data Design sklearn will try to merge into sklearn

Comments

@jovo
Copy link
Member

jovo commented Jun 5, 2020

No description provided.

@jdey4 jdey4 added the ndd Neuro Data Design label Aug 5, 2020
@jovo jovo added the sklearn will try to merge into sklearn label Aug 9, 2020
@bstraus1
Copy link
Contributor

bstraus1 commented Sep 2, 2020

Can part of this issue be assigned to me?

@jovo
Copy link
Member Author

jovo commented Sep 2, 2020

done, choose your part, and make a new issue, and reference this issue in it.

@bstraus1
Copy link
Contributor

bstraus1 commented Sep 6, 2020

Clarification needed: does this issue refer to commenting and adding variable/function descriptions for network.py and forest.py OR adding the overview/documentation sections on the landing page of the repository?

@jdey4
Copy link
Collaborator

jdey4 commented Sep 6, 2020

Follow the guideline here: https://numpy.org/doc/

@bstraus1
Copy link
Contributor

bstraus1 commented Sep 7, 2020

@jdey4 Two things:
(1) Can you elaborate on which guideline you're referring to at that link?
(2) I'd like to know whether this issue refers to commenting and adding variable/function descriptions for network.py and forest.py OR adding the overview/documentation sections on the landing page of the repository.

@jdey4
Copy link
Collaborator

jdey4 commented Sep 7, 2020

If that thing doesn't help, look at this repo how it handled the docs: https://github.com/neurodata/graspy

@bstraus1
Copy link
Contributor

bstraus1 commented Sep 7, 2020

Okay, cool. And as for documenting forest.py and network.py directly, does commenting like I have begun doing in my fork seem right?

https://github.com/bstraus1/progressive-learning

@bstraus1
Copy link
Contributor

bstraus1 commented Sep 9, 2020

Issue #94 is more accurately the portion of this issue that I will be completing. I've removed myself from this issue.

@levinwil
Copy link
Collaborator

https://scikit-learn.org/stable/developers/contributing.html#documentation

  1. Add "see also" sections
  2. Specify array shapes and types

levinwil pushed a commit that referenced this issue Nov 4, 2020
jdey4 pushed a commit that referenced this issue Sep 17, 2021
Update branch 'staging' of chenyugoal/proglearn from neurodata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ndd Neuro Data Design sklearn will try to merge into sklearn
Projects
None yet
Development

No branches or pull requests

4 participants