Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package requirements #19

Merged
merged 7 commits into from
May 20, 2021
Merged

Add package requirements #19

merged 7 commits into from
May 20, 2021

Conversation

PSSF23
Copy link
Member

@PSSF23 PSSF23 commented May 19, 2021

For #18

@Michael-Ainsworth @ypeng22 @mkusman1 Please add anything missing.

@PSSF23 PSSF23 added the documentation Improvements or additions to documentation label May 19, 2021
PSSF23
PSSF23 commented May 19, 2021
View reviewed changes
Copy link
Member Author

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Packages for figures probably don't need versions?

@ypeng22
update requirments for audio
176b1f5 
added librosa and cv2
PSSF23
PSSF23 commented May 20, 2021
View reviewed changes
Copy link
Member Author

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ypeng22 The two packages you added need to have specific versions I believe.

ypeng22 and others added 4 commits May 20, 2021 07:59
@ypeng22
Update requirements.txt
9f102d7 
version nums
@Michael-Ainsworth
Update requirements for tabular
59cea94
@PSSF23
Revert "Update requirements for tabular"
47e2e5b 
This reverts commit 59cea94.
@PSSF23 @Michael-Ainsworth
Add requirements for tabular
5bb9b37 
Co-Authored-By: Michael Ainsworth <59264468+Michael-Ainsworth@users.noreply.github.com>
PSSF23
PSSF23 commented May 20, 2021
View reviewed changes
Copy link
Member Author

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Include all current requirements

@PSSF23 PSSF23 merged commit 0caba96 into main May 20, 2021
@PSSF23 PSSF23 deleted the fighter branch May 20, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypeng22 ypeng22 ypeng22 approved these changes

@Michael-Ainsworth Michael-Ainsworth Awaiting requested review from Michael-Ainsworth

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PSSF23 @ypeng22 @Michael-Ainsworth