Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove numpy nanmean warnings and also bug fix of some code #133

Merged
merged 6 commits into from
Oct 4, 2023

Conversation

adam2392
Copy link
Collaborator

@adam2392 adam2392 commented Oct 4, 2023

Fixes #

Changes proposed in this pull request:

Before submitting

  • I've read and followed all steps in the Making a pull request
    section of the CONTRIBUTING docs.
  • I've updated or added any relevant docstrings following the syntax described in the
    Writing docstrings section of the CONTRIBUTING docs.
  • If this PR fixes a bug, I've added a test that will fail without my fix.
  • If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

  • All GitHub Actions jobs for my pull request have passed.

Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there reason why the auc metric has the tree posterior shape change? Having a binary check is fine, but roc_auc_score can handle two classes.

@adam2392
Copy link
Collaborator Author

adam2392 commented Oct 4, 2023

Is there reason why the auc metric has the tree posterior shape change? Having a binary check is fine, but roc_auc_score can handle two classes.

No. The reason is just to limit functionality while we ensure this works. We can remove those with a minor refactor easily. Rn the code has an inline comment reminding us that this only works for n_outputs==1.

@adam2392 adam2392 merged commit 8b5a7d1 into might Oct 4, 2023
16 of 21 checks passed
@adam2392 adam2392 deleted the mightfix branch October 4, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants