Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] - Update tests & small plot bug fixes #255

Merged
merged 11 commits into from
Mar 15, 2021
Merged

[MNT] - Update tests & small plot bug fixes #255

merged 11 commits into from
Mar 15, 2021

Conversation

TomDonoghue
Copy link
Member

@TomDonoghue TomDonoghue commented Mar 14, 2021

This started as a quick bug fix for a plot thing, and then escalated a little....

Updates in this PR:

  • Bug fix: fixes labelling on a phase instantaneous frequency so it plays more nicely with subplots
  • Makes test plots more realistic, so that saved out plots are more representative and easier to check
  • Simplifies test settings and fixtures**

**We were starting to get a slightly unwieldy collection of settings and fixtures. As I was trying to generalize the plots, using more realistic signals, it became clear the mapping between test signals and settings was not super clear. So, a quick clean up which basically simplifies test signals to have one regime of (N_SECONDS, FS) for fixtures defined in conftest, and then makes any tests that need idiosyncratic custom test object definitions create their own local simulations.

Note: the changes here should be relatively simple, even if the diff is somewhat large. Should only need a relatively quick check.

@TomDonoghue TomDonoghue added the 2.2 Updates to go into a 2.2.0 release label Mar 15, 2021
@TomDonoghue TomDonoghue changed the base branch from main to simlen March 15, 2021 01:31
@TomDonoghue TomDonoghue changed the base branch from simlen to main March 15, 2021 01:32
@neurodsp-tools neurodsp-tools deleted a comment from codecov-io Mar 15, 2021
Copy link
Member

@ryanhammonds ryanhammonds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good here!

@TomDonoghue
Copy link
Member Author

Thanks for the check!

@TomDonoghue TomDonoghue merged commit 1202ce2 into main Mar 15, 2021
@TomDonoghue TomDonoghue deleted the pltfix branch March 15, 2021 19:03
@ryanhammonds ryanhammonds mentioned this pull request May 3, 2021
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.2 Updates to go into a 2.2.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants