-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce basic classes for regions of interest #396
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
ca15a7f
to
8aa6020
Compare
c615207
to
7695959
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank for this work @willGraham01, you are making a long-time goal of ours come true!
I am happy with the overall wrapping approach taken here, but I've added some comments/clarifications having to do with the naming of some arguments/properties.
Other than that, perhaps it's worth modifying __init__.py
so that we can do:
from movement.roi import LineOfInterest, PolygonOfInterest
instead of the more verbose alternative?
from movement.roi.line import LineOfInterest
from movement.roi.polygon import PolygonOfInterest
Co-authored-by: Niko Sirmpilatze <niko.sirbiladze@gmail.com>
for more information, see https://pre-commit.ci
@niksirbi All comments addressed except this discussion - this is quite important as it's user-facing so wanted to give you a chance to object to my resolution before I hit merge. If all looks good after that, feel free to press the button! |
@willGraham01 I'm fine with your resolution, just added a tiny suggestion on docstring wording. Feel free to merge after that. |
Co-authored-by: Niko Sirmpilatze <niko.sirbiladze@gmail.com>
Description
What is this PR
Why is this PR needed?
A first step towards addressing #377 - introduces the low-level classes that we will need to represent these in the codebase.
As stated on the issue, we have to use wrapper classes since inheriting from
shapely
classes is problematic. This doesn't really matter too much though - if anything, it is rather helpful for separating the underlying (and rather counter-intuitive at times)shapely
objects from the higher-level analysis functions that we're going to implement.What does this PR do?
roi
submodule, which contains a base class and two derived classes for representing RoIs.References
#377
How has this PR been tested?
Addition of tests to the testing suite.
Docs successfully build.
Is this a breaking change?
No
Does this PR require an update to the documentation?
Checklist: