Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plain C implementation of jmsh/bmsh output, -d 0/1 for output precision, accept .jnii input #1

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

plain C implementation of jmsh/bmsh output, -d 0/1 for output precision, accept .jnii input #1

wants to merge 14 commits into from

Conversation

fangq
Copy link

@fangq fangq commented Apr 18, 2022 •
edited
Loading

hi @neurolabusc, this PR includes the following additions:

  1. re-implemented save_jmsh with plain C instead of cJSON, cutting down the binary size
  2. added binary JMesh (.bmsh) output
  3. added -d 0/1 to control output precision, allow double-precision output for jmsh/bmsh/json output formats
  4. using make JSON=1, it can mesh JNIfTI (.jnii) based volumes, including those output by dcm2niix -e j enabled with this patch. a compact example .jnii file is added.

the nii2mesh binary generated by make is 152.7kB, and that by make JSON=1 is 180.8kB.

@fangq fangq mentioned this pull request Apr 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fangq @neurolabusc