Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added compatability for non-scalar targets. #263

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

nkupelioglu
Copy link
Contributor

Added a check on the number of dimensions of the target tensor. If the number of dimensions is larger than 1, then use method torch.stack to merge the tensors, else keep using torch.tensor.

  • This would work in handling non-scalar targets with minimal change.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 80.00% and no project coverage change.

Comparison is base (4b89acb) 74.57% compared to head (e11748f) 74.57%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #263   +/-   ##
========================================
  Coverage    74.57%   74.57%           
========================================
  Files           51       51           
  Lines         2800     2804    +4     
========================================
+ Hits          2088     2091    +3     
- Misses         712      713    +1     
Files Changed Coverage Δ
tonic/collation.py 84.61% <80.00%> (-1.75%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@biphasic biphasic linked an issue Aug 8, 2023 that may be closed by this pull request
@biphasic
Copy link
Member

biphasic commented Aug 8, 2023

me likes! merged

@biphasic biphasic merged commit 7be656b into neuromorphs:develop Aug 8, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collation function PadTensors only supports scalar targets
3 participants