-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: wrong range of histogram in drop_pixel #275
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #275 +/- ##
===========================================
- Coverage 76.84% 76.80% -0.04%
===========================================
Files 53 53
Lines 3001 3005 +4
===========================================
+ Hits 2306 2308 +2
- Misses 695 697 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Simon, thanks a lot for your PR! Basically the checks for empty arrays should happen in the transforms.py file and not in the functional calls. If you change that and remove the AUTHORS/ChangeLog files it should be good! Thank you
Added: - test for empty frame for ToFrame and UniformNoise transforms - test boundaries of DropPixel transform for hot pixels in sensors of unequal size Modified: - Check for empty frames in ToFrame and UniformNoise outside of functional
Added: - test for empty array in DropPixel transform Modified: - check for empty array happens in DropPixel transform, not functional
No description provided.