Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: wrong range of histogram in drop_pixel #275

Merged
merged 5 commits into from
Dec 15, 2023
Merged

Fix: wrong range of histogram in drop_pixel #275

merged 5 commits into from
Dec 15, 2023

Conversation

narduzzi
Copy link
Contributor

@narduzzi narduzzi commented Dec 5, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3ce48ad) 76.84% compared to head (d56d771) 76.80%.

Files Patch % Lines
tonic/functional/drop_pixel.py 50.00% 1 Missing ⚠️
tonic/functional/to_frame.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #275      +/-   ##
===========================================
- Coverage    76.84%   76.80%   -0.04%     
===========================================
  Files           53       53              
  Lines         3001     3005       +4     
===========================================
+ Hits          2306     2308       +2     
- Misses         695      697       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@biphasic biphasic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Simon, thanks a lot for your PR! Basically the checks for empty arrays should happen in the transforms.py file and not in the functional calls. If you change that and remove the AUTHORS/ChangeLog files it should be good! Thank you

tonic/functional/to_frame.py Outdated Show resolved Hide resolved
AUTHORS Outdated Show resolved Hide resolved
tonic/functional/drop_pixel.py Outdated Show resolved Hide resolved
tonic/functional/uniform_noise.py Outdated Show resolved Hide resolved
Added:
- test for empty frame for ToFrame and UniformNoise transforms
- test boundaries of DropPixel transform for hot pixels in sensors of unequal size

Modified:
- Check for empty frames in ToFrame and UniformNoise outside of functional
Added:
- test for empty array in DropPixel transform

Modified:
- check for empty array happens in DropPixel transform, not functional
@biphasic biphasic merged commit 52de696 into neuromorphs:develop Dec 15, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants