Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a DVS eye tracking dataset from the paper 3ET #276

Merged
merged 9 commits into from
Dec 22, 2023

Conversation

ZuowenWang0000
Copy link
Contributor

The new tonic/datasets/threeET_eyetracking.py provides a new dataset from the paper 3ET: Efficient Event-based Eye Tracking using a Change-Based ConvLSTM Network (https://arxiv.org/pdf/2308.11771.pdf)

Thanks for maintaining this wonderful DVS dataset library.

Copy link
Member

@biphasic biphasic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Zuowen! This is great stuff! Please add your dataset in the docs so that others can see it https://github.com/neuromorphs/tonic/blob/develop/docs/datasets.rst
and create a test case https://github.com/neuromorphs/tonic/blob/develop/test/test_datasets.py
if you need a small test file uploaded somewhere for the test just post it here and I'll upload it.
Thanks a lot!

@ZuowenWang0000
Copy link
Contributor Author

hello Gregor,
thanks for your info! I have added the entry to the documentation and I made a test case for the loader. Could you help unzip and upload these two files under a folder?
thanks again!

testcase.zip

@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (3ce48ad) 76.84% compared to head (83e82ae) 77.01%.
Report is 11 commits behind head on develop.

Files Patch % Lines
tonic/datasets/threeET_eyetracking.py 82.22% 8 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #276      +/-   ##
===========================================
+ Coverage    76.84%   77.01%   +0.17%     
===========================================
  Files           53       54       +1     
  Lines         3001     3059      +58     
===========================================
+ Hits          2306     2356      +50     
- Misses         695      703       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@biphasic
Copy link
Member

perfect, thanks a lot. Here are the links to the two uploaded files:
testcase.txt https://nextcloud.lenzgregor.com/s/G6ejNmXNnB2sKyc
testcase.h5 https://nextcloud.lenzgregor.com/s/4aiA4BAqz5km4Gc

@biphasic
Copy link
Member

this looks great now! Nicely done. Are you happy for me to merge?

@ZuowenWang0000
Copy link
Contributor Author

yes please merge. thanks!

@biphasic biphasic merged commit debdd2e into neuromorphs:develop Dec 22, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants