Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more python models to the modeldb-run.yaml #41

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

kotsaloscv
Copy link

@kotsaloscv kotsaloscv commented Jun 21, 2022

Related to #39

@kotsaloscv kotsaloscv requested a review from alexsavulescu June 21, 2022 15:29
@kotsaloscv kotsaloscv self-assigned this Jun 21, 2022
@kotsaloscv kotsaloscv marked this pull request as draft June 22, 2022 11:29
@kotsaloscv kotsaloscv marked this pull request as ready for review June 22, 2022 15:46
@kotsaloscv
Copy link
Author

@alexsavulescu all the models with mosinit.py & run.py files (18 models) have been integrated in the modeldb-run.yaml.
Therefore, this PR is ready to be reviewed.
Thanks for helping!

@kotsaloscv
Copy link
Author

now the remaining question is how many more models have python-ready scripts. Next step is a wider investigation.

@alexsavulescu alexsavulescu force-pushed the kotsalos/python_models branch from 93fdb7a to 8f1902d Compare June 24, 2022 08:41
@alexsavulescu
Copy link
Member

To run all python models:

 runmodels --workdir=py 156039 194897 226422 186768 189922 195615 139421 144586 244412 39948 195569 249404 206400 144511 229276 151282 264834 151685

@alexsavulescu alexsavulescu marked this pull request as draft June 24, 2022 14:17
@alexsavulescu alexsavulescu force-pushed the kotsalos/python_models branch 3 times, most recently from fc9bc6a to 5c91540 Compare June 24, 2022 14:29
@@ -80,7 +80,8 @@ jobs:
- name: Set models to run for PR
run: |
# Select a few models to run CI for PRs
echo 'MODELS_TO_RUN=279 3264 22203 144549 105507 194897' >> $GITHUB_ENV
#TODO - temporary run added python models
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminder to revert this

@alexsavulescu alexsavulescu force-pushed the kotsalos/python_models branch from 5c91540 to 492b953 Compare June 24, 2022 15:05
@alexsavulescu alexsavulescu force-pushed the kotsalos/python_models branch 2 times, most recently from 7b4cb67 to e73f28b Compare June 25, 2022 00:11
* 229276 has mosinit.hoc
* reduce sim times & close plots
@alexsavulescu alexsavulescu force-pushed the kotsalos/python_models branch from e73f28b to f709d15 Compare June 25, 2022 00:23
@alexsavulescu
Copy link
Member

CI hanging again, we need to think about a better way of launching python models. Or at least make the error reporting in NEURON more robust, as I get the impression that the hang is because the simulation drop to the hoc interpreter and doesn't exit. Would be nice to reproduce this and open a ticket in NEURON.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants