Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix MUSIC setup.py and add coverage #2209

Closed
wants to merge 2 commits into from
Closed

fix MUSIC setup.py and add coverage #2209

wants to merge 2 commits into from

Conversation

alexsavulescu
Copy link
Member

No description provided.

@alexsavulescu alexsavulescu marked this pull request as draft February 6, 2023 15:30
@alexsavulescu alexsavulescu mentioned this pull request Feb 6, 2023
Merged
@alexsavulescu alexsavulescu requested a review from ohm314 February 6, 2023 15:55
ohm314
ohm314 approved these changes Feb 6, 2023
View reviewed changes
Copy link
Member

@ohm314 ohm314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look reasonable

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #100156 (:white_check_mark:) have been uploaded here!

Status and direct links:

@azure-pipelines
Copy link

✔️ 390179c -> Azure artifacts URL

@alexsavulescu alexsavulescu force-pushed the fix-music-and-cov branch 4 times, most recently from d6906c5 to a15d446 Compare February 6, 2023 21:15
@azure-pipelines
Copy link

✔️ 06ce9c7 -> Azure artifacts URL

@alexsavulescu
Copy link
Member Author

Looks to me MUSIC implementation is not complete? Not sure how #2091 plays in here ..

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #100222 (:white_check_mark:) have been uploaded here!

Status and direct links:

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #100223 (:no_entry:) have been uploaded here!

Status and direct links:

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #100453 (:no_entry:) have been uploaded here!

Status and direct links:

@alexsavulescu alexsavulescu mentioned this pull request Feb 8, 2023
Merged
@alexsavulescu
Copy link
Member Author

Merged into #2092

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #100586 (:no_entry:) have been uploaded here!

Status and direct links:

alexsavulescu added a commit that referenced this pull request Feb 8, 2023
@alexsavulescu
MUSIC + MPI multiple includes fix from #2209
07f38a4
alexsavulescu added a commit that referenced this pull request Feb 8, 2023
@alexsavulescu
remove distutils usage + fix & add MUSIC basic CI tests (#2193)
799a104 
* remove distutils usage
  * follow PEP632
  * add own `strtobool`
  * use new_compiler from setuptools build_ext for now

* `python setup.py install` is deprecated (and problematic see -> #1605)
  * update NRN_ENABLE_MODULE_INSTALL logic
  * modules installed in default location

* drop `SETUPTOOLS_USE_DISTUTILS=stdlib`
* MUSIC + MPI multiple includes fix from #2209
* MUSIC CI basic tests
nrnhines pushed a commit that referenced this pull request Sep 6, 2023
@alexsavulescu @nrnhines
remove distutils usage + fix & add MUSIC basic CI tests (#2193)
c72e0a3 
* remove distutils usage
  * follow PEP632
  * add own `strtobool`
  * use new_compiler from setuptools build_ext for now

* `python setup.py install` is deprecated (and problematic see -> #1605)
  * update NRN_ENABLE_MODULE_INSTALL logic
  * modules installed in default location

* drop `SETUPTOOLS_USE_DISTUTILS=stdlib`
* MUSIC + MPI multiple includes fix from #2209
* MUSIC CI basic tests
JCGoran pushed a commit that referenced this pull request Jan 12, 2024
@alexsavulescu @JCGoran
remove distutils usage + fix & add MUSIC basic CI tests (#2193)
8301269 
* remove distutils usage
  * follow PEP632
  * add own `strtobool`
  * use new_compiler from setuptools build_ext for now

* `python setup.py install` is deprecated (and problematic see -> #1605)
  * update NRN_ENABLE_MODULE_INSTALL logic
  * modules installed in default location

* drop `SETUPTOOLS_USE_DISTUTILS=stdlib`
* MUSIC + MPI multiple includes fix from #2209
* MUSIC CI basic tests
JCGoran pushed a commit that referenced this pull request Jan 12, 2024
@alexsavulescu @JCGoran
remove distutils usage + fix & add MUSIC basic CI tests (#2193)
043a2c2 
* remove distutils usage
  * follow PEP632
  * add own `strtobool`
  * use new_compiler from setuptools build_ext for now

* `python setup.py install` is deprecated (and problematic see -> #1605)
  * update NRN_ENABLE_MODULE_INSTALL logic
  * modules installed in default location

* drop `SETUPTOOLS_USE_DISTUTILS=stdlib`
* MUSIC + MPI multiple includes fix from #2209
* MUSIC CI basic tests
JCGoran pushed a commit that referenced this pull request Jan 16, 2024
@alexsavulescu @JCGoran
remove distutils usage + fix & add MUSIC basic CI tests (#2193)
75599aa 
* remove distutils usage
  * follow PEP632
  * add own `strtobool`
  * use new_compiler from setuptools build_ext for now

* `python setup.py install` is deprecated (and problematic see -> #1605)
  * update NRN_ENABLE_MODULE_INSTALL logic
  * modules installed in default location

* drop `SETUPTOOLS_USE_DISTUTILS=stdlib`
* MUSIC + MPI multiple includes fix from #2209
* MUSIC CI basic tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohm314 ohm314 ohm314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexsavulescu @bbpbuildbot @ohm314