Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GPU wheels #2378

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Remove GPU wheels #2378

merged 2 commits into from
Jun 8, 2023

Conversation

olupton
Copy link
Collaborator

@olupton olupton commented Jun 8, 2023 •
edited
Loading

  • Remove the current incarnation of neuron-gpu[-nightly].
  • This was stuck on an old NVIDIA toolchain version, and had usability issues that we believe had prevented widespread adoption.

@olupton olupton force-pushed the olupton/no-more-gpu-wheels branch from f64173a to ad90079 Compare June 8, 2023 10:45
@olupton olupton requested review from alexsavulescu and pramodk June 8, 2023 11:19
@olupton olupton marked this pull request as ready for review June 8, 2023 11:19
@azure-pipelines
Copy link

✔️ ad90079 -> Azure artifacts URL

@olupton olupton requested review from ohm314 and iomaganaris June 8, 2023 11:21
alexsavulescu
alexsavulescu approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@alexsavulescu alexsavulescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Shall we add an entry in removed_features.rst ?

@codecov
Copy link

codecov bot commented Jun 8, 2023 •
edited
Loading

Codecov Report

Merging #2378 (d8ef631) into master (fb17127) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2378   +/-   ##
=======================================
  Coverage   60.15%   60.15%           
=======================================
  Files         642      642           
  Lines      121135   121135           
=======================================
  Hits        72872    72872           
  Misses      48263    48263

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bbpbuildbot

This comment has been minimized.

Sign in to view
@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines
Copy link

✔️ d8ef631 -> Azure artifacts URL

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #130024 (:white_check_mark:) have been uploaded here!

Status and direct links:

@olupton olupton merged commit b94c5c3 into master Jun 8, 2023
@olupton olupton deleted the olupton/no-more-gpu-wheels branch June 8, 2023 15:00
@olupton olupton mentioned this pull request Jul 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pramodk pramodk pramodk left review comments

@alexsavulescu alexsavulescu alexsavulescu approved these changes

@ohm314 ohm314 Awaiting requested review from ohm314

@iomaganaris iomaganaris Awaiting requested review from iomaganaris

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olupton @bbpbuildbot @pramodk @alexsavulescu