Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added documentation for execution workflows #2405

Merged
merged 12 commits into from
Jun 30, 2023
Merged

Added documentation for execution workflows #2405

merged 12 commits into from
Jun 30, 2023

Conversation

iomaganaris
Copy link
Member

  • Focused on the most important parts of the simulation workflow

@iomaganaris iomaganaris self-assigned this Jun 25, 2023
@azure-pipelines
Copy link

✔️ 55bdf12 -> Azure artifacts URL

@codecov
Copy link

codecov bot commented Jun 25, 2023 •
edited
Loading

Codecov Report

Merging #2405 (e594170) into master (e029076) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2405   +/-   ##
=======================================
  Coverage   60.20%   60.20%           
=======================================
  Files         627      627           
  Lines      121063   121063           
=======================================
  Hits        72888    72888           
  Misses      48175    48175

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bbpbuildbot

This comment has been minimized.

Sign in to view
alexsavulescu
alexsavulescu approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@alexsavulescu alexsavulescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One suggestion, to propose Python first over HOC

@iomaganaris @alexsavulescu
Apply suggestions from Alex's code review
301fcd9 
Co-authored-by: Alexandru Săvulescu <alexandru.savulescu@epfl.ch>
olupton
olupton reviewed Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@olupton olupton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I enabled a build of this at: https://nrn.readthedocs.io/en/magkanar-docs/dev/workflow-code-paths.html

docs/dev/workflow-code-paths.rst Show resolved Hide resolved
docs/dev/execution_flow.svg Outdated Show resolved Hide resolved
olupton
olupton reviewed Jun 26, 2023
View reviewed changes
docs/dev/initialization.svg Outdated Show resolved Hide resolved
docs/dev/insert_mechanism.svg Outdated Show resolved Hide resolved
docs/dev/mechanism_registration.svg Outdated Show resolved Hide resolved
docs/dev/workflow-code-paths.rst Outdated Show resolved Hide resolved
@azure-pipelines
Copy link

✔️ 301fcd9 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines
Copy link

✔️ 2aa6d56 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@azure-pipelines
Copy link

✔️ e594170 -> Azure artifacts URL

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #135555 (:white_check_mark:) have been uploaded here!

Status and direct links:

@alexsavulescu alexsavulescu merged commit f800f52 into master Jun 30, 2023
@alexsavulescu alexsavulescu deleted the magkanar/docs branch June 30, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexsavulescu alexsavulescu alexsavulescu approved these changes

@olupton olupton olupton approved these changes

Assignees

@iomaganaris iomaganaris

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iomaganaris @bbpbuildbot @olupton @alexsavulescu