Remove toggling of TABLE from hh.mod (CoreNEURON + NMODL compatibility) #3093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity) - We were commenting TABLE statement from hh.mod as TABLE statement was not supported in mod2c. - NMODL on CoreNEURON side supports TABLE statements also on GPU side. - Hence, we can remove the CMake toggling logic for TABLE. - Also update the references for tests fixes #1764
|
✔️ 3b2697f -> Azure artifacts URL |
pramodk
added a commit
to neuronsimulator/ringtest
that referenced
this pull request
Sep 24, 2024
|
✔️ 580db32 -> Azure artifacts URL |
pramodk
added a commit
to neuronsimulator/testcorenrn
that referenced
this pull request
Sep 25, 2024
pramodk
added a commit
to neuronsimulator/ringtest
that referenced
this pull request
Sep 25, 2024
|
✔️ ff8335b -> Azure artifacts URL |
|
✔️ ee44c4a -> Azure artifacts URL |
nrnhines
approved these changes
Sep 25, 2024
pramodk
added a commit
to neuronsimulator/testcorenrn
that referenced
this pull request
Sep 25, 2024
pramodk
added a commit
to neuronsimulator/ringtest
that referenced
this pull request
Sep 25, 2024
|
|
✔️ d7f8f34 -> Azure artifacts URL |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3093 +/- ##
==========================================
+ Coverage 67.84% 67.86% +0.01%
==========================================
Files 572 572
Lines 104210 104210
==========================================
+ Hits 70702 70717 +15
+ Misses 33508 33493 -15 ☔ View full report in Codecov by Sentry. |
JCGoran
pushed a commit
that referenced
this pull request
Oct 31, 2024
- We were commenting TABLE statement from hh.mod as TABLE statement was not supported in mod2c. - NMODL on CoreNEURON side supports TABLE statements also on GPU side. - Hence, we can remove the CMake toggling logic for TABLE. - Also update the references for tests in ringtest and testcorenrn repos fixes #1764
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the CMake logic that toggled the
TABLEconstruct inhh.mod.NMODL now supports
TABLEstatements, including in GPU builds, on the CoreNEURON side.Updated relevant test references to reflect this change.
Merge first Update spike reference data with TABLE ringtest#28
Merge Update results with TABLE statements testcorenrn#14
fixes #1764