Feat 839 update visualizer with niivue #861
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…visualizer-with-niivue
…39-update-visualizer-with-niivue
…39-update-visualizer-with-niivue
|
The feedback that I received from this PR is that the niivue min and max should be adjustable, and that some of the values disappear when the max is increased (even though they are above some threshold). These are issues to be fixed on the niivue side. I've raised an issue, and it is being addresses via this PR |
|
No mechanism exists in which we can allow for a soft threshold (translucent subthreshold) AND provide an adjustable min value it seems. We can only choose either (1) having an adjustable min or (2) having the translucent sub threshold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.