Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: expire running deprecations in prep for 4.0 rel #341

Merged
merged 1 commit into from
Oct 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- DEP: bump minimal and pinned `inifix` from 3.0.0 to 4.2.2
- DEPR: rename print_err to print_error, deprecate old name
- ENH: add short version `-i` for `idfx digest --input ...`
- DEPR: expire running deprecations in prep for 4.0 rel

## [3.2.1] - 2023-09-06

Expand Down
7 changes: 1 addition & 6 deletions src/idefix_cli/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,7 @@
def _get_command_paths() -> list[str]:
dirs = [BASE_COMMAND_PATH]

if ext_dir_v1 := get_option("idefix_cli", "extension_dir"):
print_warning(
"The 'extension_dir' option is deprecated. Use 'plugins_directory' instead."
)

if ext_dir := get_option("idefix_cli", "plugins_directory") or ext_dir_v1:
if ext_dir := get_option("idefix_cli", "plugins_directory"):
if os.path.isdir(ext_dir):
dirs.append(ext_dir)
else:
Expand Down
11 changes: 1 addition & 10 deletions src/idefix_cli/_commands/run.py
Original file line number Diff line number Diff line change
Expand Up @@ -181,12 +181,6 @@ def add_arguments(parser) -> None:
help="target inifile",
)
tstop_group = parser.add_mutually_exclusive_group()
tstop_group.add_argument(
"--duration",
action="store",
type=float,
help="run for specified time (in code units) DEPRECATED",
)
tstop_group.add_argument(
"--tstop",
action="store",
Expand Down Expand Up @@ -342,10 +336,7 @@ def command(

if time_step is not None:
conf["TimeIntegrator"]["first_dt"] = time_step
if duration is not None:
print_warning("The --duration argument is deprecated. Use --tstop instead.")
conf["TimeIntegrator"]["tstop"] = duration
elif tstop is not None:
if tstop is not None:
conf["TimeIntegrator"]["tstop"] = tstop

rebuild_mode_str: str = get_option("idfx run", "recompile") or "always"
Expand Down