Bugs with web preset missing dev server

neutrinojs · Feb 15, 2017 · 4f1655d · 4f1655d
1 parent 02e1355
commit 4f1655d
Show file tree

Hide file tree

Showing 3 changed files with 485 additions and 12 deletions.
diff --git a/packages/neutrino-preset-web/package.json b/packages/neutrino-preset-web/package.json
@@ -28,6 +28,7 @@
     "style-loader": "0.13.1",
     "url-loader": "0.5.7",
     "webpack": "^2.2.1",
+    "webpack-dev-server": "^2.3.0",
     "webpack-merge": "^2.6.1",
     "worker-loader": "0.7.1"
   },

diff --git a/packages/neutrino-preset-web/src/index.js b/packages/neutrino-preset-web/src/index.js
@@ -17,6 +17,7 @@ const FILE_LOADER = require.resolve('file-loader');
 const CSS_LOADER = require.resolve('css-loader');
 const STYLE_LOADER = require.resolve('style-loader');
 const URL_LOADER = require.resolve('url-loader');
+const PROJECT_MODULES = path.join(CWD, 'node_modules');
 const MODULES = path.join(__dirname, '../node_modules');
 
 module.exports = ({ config }) => {
@@ -181,7 +182,9 @@ module.exports = ({ config }) => {
         names: ['vendor', 'manifest'],
         minChunks: Infinity
       });
-  } else if (process.env.NODE_ENV === 'development') {
+  }
+
+  if (process.env.NODE_ENV === 'development') {
     const protocol = !!process.env.HTTPS ? 'https' : 'http';
     const host = process.env.HOST || 'localhost';
     const port = parseInt(process.env.PORT) || 5000;
@@ -217,9 +220,7 @@ module.exports = ({ config }) => {
     config
       .plugin('hot')
       .use(webpack.HotModuleReplacementPlugin);
-  }
-
-  if (process.env.NODE_ENV !== 'development') {
+  } else {
     config.output.filename('[name].[chunkhash].bundle.js');
 
     config