Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Enable more eslint-plugin-jest rules by default #1202

Closed
edmorley opened this issue Nov 8, 2018 · 0 comments
Closed

Enable more eslint-plugin-jest rules by default #1202

edmorley opened this issue Nov 8, 2018 · 0 comments

Comments

@edmorley
Copy link
Member

edmorley commented Nov 8, 2018

eslint-plugin-jest has a recommended rule set, which we're not using:
https://github.com/jest-community/eslint-plugin-jest#recommended

rules: {
'jest/no-disabled-tests': 'warn',
'jest/no-focused-tests': 'error',
'jest/no-identical-title': 'error',
'jest/valid-expect': 'error'
}

I think we should use it in @neutrinojs/jest instead of only manually enabling a handful of rules.

Thoughts?

Also the v22 release of eslint-plugin-jest added a new style preset configuration alongside recommended:
jest-community/eslint-plugin-jest#193
https://github.com/jest-community/eslint-plugin-jest#style

Should we use that too?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

1 participant