Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Remove web preset dependency on @neutrinojs/image-minify #700

Closed
edmorley opened this issue Jan 30, 2018 · 4 comments · Fixed by #815
Closed

Remove web preset dependency on @neutrinojs/image-minify #700

edmorley opened this issue Jan 30, 2018 · 4 comments · Fixed by #815

Comments

@edmorley
Copy link
Member

Since it increases the yarn install time significantly due to the number of compiled packages and yarnpkg/yarn#932. The feature is disabled by default, however this is still a breaking change so would need to wait until Neutrino 9.

See:
#673 (comment)

@timkelty
Copy link
Contributor

At the same time, lets consider if it is worth it to continue the aggregate @neutrinojs/minify, or if they should just exist separately.

@timkelty
Copy link
Contributor

timkelty commented Jan 30, 2018

Related issues and discussion with "default" minification: #678, #673

@ftes
Copy link

ftes commented Mar 21, 2018

Also valuable to avoid compilations on CI servers which may not have required build tools.

E.g. the mozjpeg build requires autoreconf, and the pngquant build requires libpng-dev.

✖ Error: autoreconf -fiv && ./configure --disable-shared --prefix=".../node_modules/mozjpeg/vendor" ... && make --jobs=8 && make install --jobs=8
/bin/sh: autoreconf: command not found
✖ Error: pngquant failed to build, make sure that libpng-dev is installed

@edmorley
Copy link
Member Author

Fixed by #815 which will be in Neutrino 9.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging a pull request may close this issue.

3 participants