This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Split up the minify preset #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 24, 2018
eliperelman
approved these changes
Apr 24, 2018
| @@ -2,32 +2,42 @@ import test from 'ava'; | |||
| import { Neutrino } from 'neutrino'; | |||
|
|
|||
| const mw = () => require('..'); | |||
| const prodEnv = { 'env': { NODE_ENV: 'production' } }; | |||
There was a problem hiding this comment.
We can remove the string from the env key.
| @@ -2,32 +2,42 @@ import test from 'ava'; | |||
| import { Neutrino } from 'neutrino'; | |||
|
|
|||
| const mw = () => require('..'); | |||
| const prodEnv = { 'env': { NODE_ENV: 'production' } }; | |||
| const devEnv = { 'env': { NODE_ENV: 'development' } }; | |||
There was a problem hiding this comment.
We can remove the string from the env key.
* Removes the web preset's dependency on `@neutrinojs/image-minify` since it has many heavyweight native code dependencies, and isn't enabled by default anyway (see #713). * Removes the library preset's dependency on `@neutrinojs/style-minify` and `@neutrinojs/image-minify` (fixes #807). * Removes the `@neutrinojs/minify` preset in favour of directly depending on the individual `@neutrinojs/*-minify` presets. * Adds an `enabled` option to `@neutrinojs/image-minify` that defaults to production only, to allow for string form usage of the preset in `.neutrinorc.js`, without the need to specify a `.when()`.
|
I think this also fixes #670 in master. |
|
Though presumably anyone who explicitly adds the |
|
Correct. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@neutrinojs/image-minifysince it has many heavyweight native code dependencies, and isn't enabled by default anyway (fixes Remove web preset dependency on @neutrinojs/image-minify #700 and see also Scale back default minification in core presets #713).@neutrinojs/style-minifyand@neutrinojs/image-minify(fixes The library preset enables all types of minification by default #807).@neutrinojs/minifypreset in favour of directly depending on the individual@neutrinojs/*-minifypresets.enabledoption to@neutrinojs/image-minifythat defaults to production only, to allow for string form usage of the preset in.neutrinorc.js, without the need to specify a.when().