You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
`@neutrinojs/preact` already had a dependency on `eslint-plugin-react`,
but wasn't actually using it. Now the React ESLint plugin is enabled
if an ESLint configuration is found - the same as for the React preset.
This will make it easier for Preact users to realise what changes they
need to make, now that we're not using `babel-plugin-jsx-pragmatic`.
Fixes#821.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Spotted whilst working on babel 7.
The
@neutrinojs/preact
currently depends on eslint-plugin-react:https://github.com/mozilla-neutrino/neutrino-dev/blob/082515268e3587e065989c787c0bd35b6f6b8dab/packages/preact/package.json#L37
...however it doesn't activate the
react
plugin (unlike@neutrinojs/react
):https://github.com/mozilla-neutrino/neutrino-dev/blob/082515268e3587e065989c787c0bd35b6f6b8dab/packages/preact/index.js#L50-L57
...meaning that dependency is currently unused.
We should probably activate the plugin and also set the pragma correctly, to prevent false positives. eg:
The text was updated successfully, but these errors were encountered: