This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
@neutrinojs/stylelint doesn't set failOnError #971
Comments
edmorley
added a commit
that referenced
this issue
Jul 13, 2018
Previously the only way to override `mode` was by passing `--mode` on the command line. However this is not possible with all tools, since some (such as karma) reject unrecognised arguments. Now: * `mode` is derived from `NODE_ENV` if `--mode` wasn't passed, and !production `NODE_ENV` falls back to mode `development`. * if `--mode` is passed, it takes priority over `NODE_ENV`. * if neither `mode` nor `NODE_ENV is defined, then `NODE_ENV` is set to `production`, however `mode` is left undefined, which causes webpack to output a helpful warning about relying on defaults. * the template test runner configs set a default `NODE_ENV` of `test`. * `@neutrinojs/stylelint` now also correctly sets `failOnError`. Fixes #900. Fixes #971. Closes #955.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The docs say
failOnErroris set:https://github.com/mozilla-neutrino/neutrino-dev/blame/e597c615e2c76e9986b6262249e35001a00efc0f/packages/stylelint/README.md#L44
...however the preset doesn't actually do so:
https://github.com/mozilla-neutrino/neutrino-dev/blob/e597c615e2c76e9986b6262249e35001a00efc0f/packages/stylelint/index.js#L5-L11
The text was updated successfully, but these errors were encountered: