This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linting
In order to make linting easier to configure, I have moved all the rules to be inline to the plugin config. This means that making a linting rule change just means calling the loader and changes the options rules!
Config API
I also wrote a new package called webpack-chain, which gives a fluent API for creating Webpack configs. There were other solutions to this out there, but they either didn't support Webpack 2, or didn't give us the granularity we needed to modify configs across projects.
Now any preset that inherits from our presets will get this chaining API for free to make modifications. If they want an escape hatch, they can call
.toConfig()
and just change the config object as before.Config from package.json
All too often there will be times where I just want to override something simple in the configuration, but it takes a bit of work to have to create a preset and then switch the package.json to use this new preset. This PR now also merges any Webpack config specific in
config.neutrino
with the preset config.I know this is big, but I'd appreciate a glance at this before merging, and to discuss any concerns. Thanks!