Skip to content
This repository was archived by the owner on Feb 18, 2024. It is now read-only.

Specify root option in eslintrc templates #1039

Closed
wants to merge 1 commit into from
Closed

Specify root option in eslintrc templates #1039

wants to merge 1 commit into from

Conversation

eliperelman
Copy link
Member

@eliperelman eliperelman commented Aug 23, 2018

Fixes #973.

I'm not sure how this wasn't happening before, but when running without the --no-eslintrc bits in the precommit I would get errors around eslint being unable to load the config file. I think this was related to eslint trying to load these nested eslintrc files to lint their subdirectories, which we definitely don't want during development.

So now I added --no-eslintrc -c ./.eslintrc.js so it will lint the monorepo using only our top-level eslintrc. When you run it like this though, eslint gives you warnings that the create-project eslintrc files are ignored by default, so the eslintignore line addition is to add these back to being linted, but not used as config.

@eliperelman eliperelman added this to the v9 milestone Aug 23, 2018
@eliperelman eliperelman self-assigned this Aug 23, 2018
@eliperelman eliperelman requested a review from edmorley August 23, 2018 17:22
@edmorley
Copy link
Member

I'm not sure I follow the --no-eslintrc bits. Were the files not being linted before?
Could you add some more explanation to the PR description? :-)

@eliperelman
Copy link
Member Author

@edmorley updated. I honestly don't know if they were being linted before or not at this point. 🤣

@edmorley
Copy link
Member

If Travis isn't triggered I would recommend amending the commit (or rebasing if applicable) and then force pushing over closing/opening the PR (creates less notification emails).

@eliperelman
Copy link
Member Author

Yeah, this is closed because I deleted the fork. 😢

@edmorley edmorley removed this from the v9 milestone Aug 23, 2018
@edmorley
Copy link
Member

Ah! :-)

@edmorley edmorley removed their request for review November 7, 2018 17:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

2 participants